webview-ui/src/i18n/locales/es/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix garbled UTF-8 text in Spanish locale strings.

Line 455 and Line 871 contain mojibake, so these messages will display corrupted characters in the UI.

💡 Proposed fix

-		"googleCloudCredentialsPathWarning": "Este campo espera el contenido JSON de un archivo de clave de cuenta de servicio, no una ruta. Si tienes una ruta, pégala en el campo <strong>Ruta del archivo de clave de Google Cloud</strong> a continuación, o borra este campo y utiliza la variable de entorno <code>GOOGLE_APPLICATION_CREDENTIALS</code>.",
+		"googleCloudCredentialsPathWarning": "Este campo espera el contenido JSON de un archivo de clave de cuenta de servicio, no una ruta. Si tienes una ruta, pégala en el campo <strong>Ruta del archivo de clave de Google Cloud</strong> a continuación, o borra este campo y utiliza la variable de entorno <code>GOOGLE_APPLICATION_CREDENTIALS</code>.",
@@
-		"automaticFetch": "La extensión obtiene automáticamente la lista más reciente de modelos disponibles en <serviceLink>{{serviceName}}</serviceLink>. Si no está seguro de qué modelo elegir, Zoo Code funciona mejor con <defaultModelLink>{{defaultModelId}}</defaultModelLink>. También puede buscar \"free\" para opciones sin costo actualmente disponibles.",
+		"automaticFetch": "La extensión obtiene automáticamente la lista más reciente de modelos disponibles en <serviceLink>{{serviceName}}</serviceLink>. Si no está seguro de qué modelo elegir, Zoo Code funciona mejor con <defaultModelLink>{{defaultModelId}}</defaultModelLink>. También puede buscar \"free\" para opciones sin costo actualmente disponibles.",

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/es/settings.json` at line 455, The Spanish locale
string under the key "googleCloudCredentialsPathWarning" contains mojibake
(e.g., "pégala", "a continuación"); update that value to use proper UTF-8
accented characters (e.g., "pégala", "a continuación") and scan the same file
for the other affected key around line 871 to fix similar garbled sequences so
all Spanish strings are valid UTF-8.

src/api/providers/fetchers/zoo-gateway.ts-68-77 (1)

68-77: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Skip model discovery when there is no session token.

Line 59 states auth is required, but Lines 68-77 still issue a network call without credentials. That creates guaranteed failures and noisy logs for signed-out users.

💡 Proposed fix

-	const sessionToken = options?.zooSessionToken || getCachedZooCodeToken()
-	const headers: Record<string, string> = {}
-	if (sessionToken) {
-		headers["Authorization"] = `Bearer ${sessionToken}`
-	}
+	const sessionToken = options?.zooSessionToken ?? getCachedZooCodeToken()
+	if (!sessionToken) {
+		return models
+	}
+	const headers: Record<string, string> = {
+		Authorization: `Bearer ${sessionToken}`,
+	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/api/providers/fetchers/zoo-gateway.ts` around lines 68 - 77, The code
issues an axios.get to `${baseURL}/models` even when no session token is
available (sessionToken from options?.zooSessionToken || getCachedZooCodeToken),
causing needless failed requests; update the logic to short-circuit before the
network call when sessionToken is falsy (e.g., return an empty models list or
null from the enclosing function), so do not call axios.get or use
MODEL_DISCOVERY_TIMEOUT_MS without credentials—use the sessionToken variable and
the axios.get call sites as the anchors to implement the early return.

webview-ui/src/i18n/locales/de/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the mojibake in these German strings.

Both translated values are corrupted, so googleCloudCredentialsPathWarning and modelPicker.automaticFetch will render as unreadable text in the settings UI.

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/de/settings.json` at line 455, The German strings
contain mojibake where umlauts were corrupted; update the values for the keys
googleCloudCredentialsPathWarning and modelPicker.automaticFetch in the locales
file to use the correct German characters (e.g., "Schlüssel" and
"Schlüsseldateipfad") so the messages read correctly—specifically replace
"Schl├╝ssel" and "Schl├╝sseldateipfad" with "Schlüssel" and "Schlüsseldateipfad"
and ensure the rest of the punctuation/HTML/templating (like <strong> and
<code>) remains unchanged.

webview-ui/src/i18n/locales/tr/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the mojibake in these Turkish strings.

googleCloudCredentialsPathWarning and modelPicker.automaticFetch are corrupted here, so the translated settings copy will render unreadably.

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/tr/settings.json` at line 455, The Turkish
strings for keys googleCloudCredentialsPathWarning and
modelPicker.automaticFetch contain mojibake (corrupted characters); open the
localization entries for these keys, replace the corrupted characters with the
correct Turkish characters/words (e.g., restore characters like ı, ş, ç, ğ, ö,
ü) so the sentences read naturally, ensure the file is saved in UTF-8 without
BOM, and also fix the identical corrupted instance noted around the other
occurrence (modelPicker.automaticFetch) so both entries render correctly.

webview-ui/src/i18n/locales/zh-TW/settings.json-465-465 (1)

465-465: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the mojibake in these Traditional Chinese strings.

Both values are corrupted, so googleCloudCredentialsPathWarning and modelPicker.automaticFetch will show unreadable text in the UI.

Also applies to: 881-881

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/zh-TW/settings.json` at line 465, The Traditional
Chinese strings for the keys googleCloudCredentialsPathWarning and
modelPicker.automaticFetch are corrupted (mojibake); locate the JSON entries for
"googleCloudCredentialsPathWarning" and "modelPicker.automaticFetch" and replace
the garbled text with correct Traditional Chinese translations, preserving any
inline HTML tags like <strong> and <code> and ensuring the meaning about setting
GOOGLE_APPLICATION_CREDENTIALS and automatic model fetching remains accurate;
also fix the duplicate occurrence noted (the other affected entry around the
second mention) so both occurrences show readable Traditional Chinese.

webview-ui/src/i18n/locales/pt-BR/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix mojibake in Portuguese translations.

These strings are UTF-8 corrupted and will render broken text in UI.

💡 Suggested fix

-		"googleCloudCredentialsPathWarning": "Este campo espera o conteúdo JSON de um arquivo de chave de conta de serviço, não um caminho. Se você tiver um caminho, cole-o no campo <strong>Caminho do Arquivo de Chave Google Cloud</strong> abaixo, ou limpe este campo e use a variável de ambiente <code>GOOGLE_APPLICATION_CREDENTIALS</code>.",
+		"googleCloudCredentialsPathWarning": "Este campo espera o conteúdo JSON de um arquivo de chave de conta de serviço, não um caminho. Se você tiver um caminho, cole-o no campo <strong>Caminho do Arquivo de Chave Google Cloud</strong> abaixo, ou limpe este campo e use a variável de ambiente <code>GOOGLE_APPLICATION_CREDENTIALS</code>.",
@@
-		"automaticFetch": "A extensão busca automaticamente a lista mais recente de modelos disponíveis em <serviceLink>{{serviceName}}</serviceLink>. Se você não tem certeza sobre qual modelo escolher, o Zoo Code funciona melhor com <defaultModelLink>{{defaultModelId}}</defaultModelLink>. Você também pode pesquisar por \"free\" para encontrar opções gratuitas atualmente disponíveis.",
+		"automaticFetch": "A extensão busca automaticamente a lista mais recente de modelos disponíveis em <serviceLink>{{serviceName}}</serviceLink>. Se você não tem certeza sobre qual modelo escolher, o Zoo Code funciona melhor com <defaultModelLink>{{defaultModelId}}</defaultModelLink>. Você também pode pesquisar por \"free\" para encontrar opções gratuitas atualmente disponíveis.",

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/pt-BR/settings.json` at line 455, The Portuguese
translation for the key "googleCloudCredentialsPathWarning" (and the other
affected key around the same area) contains mojibake (UTF-8 corruption) and must
be replaced with correctly encoded UTF-8 text; locate the
"googleCloudCredentialsPathWarning" entry in the pt-BR locale and update the
string to use proper Portuguese characters (e.g., "conteúdo", "conta de
serviço", "não", "você", "variável de ambiente", "Caminho do Arquivo de Chave
Google Cloud") so the UI renders correctly; ensure the same corrections are
applied to the other corrupted pt-BR string referenced in the review.

webview-ui/src/i18n/locales/it/settings.json-871-871 (1)

871-871: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix corrupted UTF-8 in Italian modelPicker.automaticFetch.

The string includes mojibake (pi├╣) and will display incorrectly.

💡 Suggested fix

-		"automaticFetch": "L'estensione recupera automaticamente l'elenco pi├╣ recente dei modelli disponibili su <serviceLink>{{serviceName}}</serviceLink>. Se non sei sicuro di quale modello scegliere, Zoo Code funziona meglio con <defaultModelLink>{{defaultModelId}}</defaultModelLink>. Puoi anche cercare \"free\" per opzioni gratuite attualmente disponibili.",
+		"automaticFetch": "L'estensione recupera automaticamente l'elenco più recente dei modelli disponibili su <serviceLink>{{serviceName}}</serviceLink>. Se non sei sicuro di quale modello scegliere, Zoo Code funziona meglio con <defaultModelLink>{{defaultModelId}}</defaultModelLink>. Puoi anche cercare \"free\" per opzioni gratuite attualmente disponibili.",

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/it/settings.json` at line 871, The value for the
i18n key modelPicker.automaticFetch contains mojibake ("pi├╣") instead of the
correct Italian character; update the string for modelPicker.automaticFetch to
replace "pi├╣ recente" with "più recente" (keep the existing HTML-like links
<serviceLink>{{serviceName}}</serviceLink> and
<defaultModelLink>{{defaultModelId}}</defaultModelLink> and preserve any escaped
quotes), ensuring the file is saved as UTF-8 so the "ù" character is stored
correctly.

src/core/webview/__tests__/ClineProvider.spec.ts-3760-3771 (1)

3760-3771: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Assert the state refresh you claim in the test.

This case only verifies the log path. A regression where handleZooCodeCallback() stops calling postStateToWebview() would still pass, despite the test name promising that behavior. Add an explicit expect(provider.postStateToWebview).toHaveBeenCalled() or rename the test.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/webview/__tests__/ClineProvider.spec.ts` around lines 3760 - 3771,
The test "logs and posts state when profile persistence fails" currently only
asserts the log path; update the spec to also assert that
provider.postStateToWebview was invoked after calling
provider.handleZooCodeCallback("zoo_ext_token") (or alternatively rename the
test to reflect it only verifies logging). Specifically, locate the test using
provider.handleZooCodeCallback and add an
expect(provider.postStateToWebview).toHaveBeenCalled() (or rename the it(...)
description) so the test actually verifies the state-post behavior.

webview-ui/src/i18n/locales/ca/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the encoding corruption in these translations.

These strings contain visible mojibake, so Catalan users will see broken copy in the settings UI. Please restore the intended text and save the file with the correct encoding.

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/ca/settings.json` at line 455, The Catalan
translation for the key "googleCloudCredentialsPathWarning" contains mojibake
("a continuaci├│")—replace it with the correct text ("a continuació") and verify
the corresponding duplicate entry later in the same settings.json (the other
occurrence flagged by the reviewer) is fixed the same way; finally re-save the
file in UTF-8 (no BOM) to prevent encoding corruption going forward.

webview-ui/src/i18n/locales/fr/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Restore these French strings before merge.

Both values contain mojibake, so the settings UI will show broken text instead of proper French copy. Reinsert the intended translation and save the file as UTF-8.

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/fr/settings.json` at line 455, The JSON value for
the "googleCloudCredentialsPathWarning" key contains mojibake (garbled
characters); replace it with the correct French translation (use proper accents)
and ensure the file is saved as UTF-8; also locate and fix the other occurrence
noted (same mojibake at the other key around line 871) so both keys contain
proper French strings with correct accents and encoding.

webview-ui/src/i18n/locales/ja/settings.json-455-455 (1)

455-455: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the mojibake in these localized strings.

Both entries are unreadable in the shipped UI because the text appears to have been saved with the wrong encoding. Restore the intended Japanese copy and re-save the file as UTF-8.

Also applies to: 871-871

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/i18n/locales/ja/settings.json` at line 455, The value for the
i18n key "googleCloudCredentialsPathWarning" contains mojibake (wrong encoding);
open the locale file, replace the garbled string with the correct Japanese copy
for that key (preserving the intended inline tokens like <strong>Google
Cloud…</strong> and <code>GOOGLE_APPLICATION_CREDENTIALS</code>), ensure the
file is saved as UTF-8 (preferably UTF-8 without BOM), and apply the same fix to
the other corrupted localized entry in the same file that was flagged as also
affected.

webview-ui/src/components/settings/providers/__tests__/ZooGateway.spec.tsx (1)

150-152: ⚡ Quick win

Make the non-call assertion wait past effect flush.

This can pass too early before async effects settle, so it may miss a late setApiConfigurationField call.

Proposed test hardening

+import { act } from "`@/utils/test-utils`"
...
-		await waitFor(() => {
-			expect(setApiConfigurationField).not.toHaveBeenCalled()
-		})
+		await act(async () => {
+			await Promise.resolve()
+		})
+		expect(setApiConfigurationField).not.toHaveBeenCalled()

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@webview-ui/src/components/settings/providers/__tests__/ZooGateway.spec.tsx`
around lines 150 - 152, The non-call assertion for setApiConfigurationField in
ZooGateway.spec.tsx can pass too early; wrap the expectation in waitFor that
waits long enough for async effects (e.g., await waitFor(() =>
expect(setApiConfigurationField).not.toHaveBeenCalled(), { timeout: 1000 })) or
explicitly flush pending promises before the assertion (e.g., await
flushPromises(); expect(setApiConfigurationField).not.toHaveBeenCalled());
update the test to use one of these approaches targeting the
waitFor/setApiConfigurationField usage so the assertion runs after effects
settle.

src/core/webview/__tests__/webviewMessageHandler.spec.ts (1)

397-433: ⚡ Quick win

Harden shared mock cleanup to avoid test state bleed.

These tests mutate mockClineProvider globally and rely on inline cleanup. If a test fails early, state can leak into later tests. Move restoration to afterEach (or try/finally) for providerSettingsManager, upsertProviderProfile, and overridden contextProxy fields.

Suggested stabilization pattern

+let originalContextProxy: any
+
+beforeEach(() => {
+  originalContextProxy = mockClineProvider.contextProxy
+})
+
+afterEach(() => {
+  delete (mockClineProvider as any).providerSettingsManager
+  delete (mockClineProvider as any).upsertProviderProfile
+  ;(mockClineProvider as any).contextProxy = originalContextProxy
+})

Also applies to: 1163-1229

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/webview/__tests__/webviewMessageHandler.spec.ts` around lines 397 -
433, Tests mutate the shared mockClineProvider (providerSettingsManager,
upsertProviderProfile, contextProxy) inline which can leak state if a test
fails; instead, capture original values at test start and restore them in an
afterEach hook (or wrap each test body in try/finally), e.g. save const
origProviderSettings = (mockClineProvider as any).providerSettingsManager,
origUpsert = (mockClineProvider as any).upsertProviderProfile, origContext =
(mockClineProvider as any).contextProxy and restore them after the test; apply
this stabilization for the tests that set providerSettingsManager,
upsertProviderProfile, or override contextProxy (the block around
webviewMessageHandler and the other similar test blocks).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes